[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/14] qapi: convert block_passwd and add set-bl
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 09/14] qapi: convert block_passwd and add set-blockdev-password |
Date: |
Thu, 25 Aug 2011 14:29:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 |
Am 24.08.2011 20:43, schrieb Anthony Liguori:
> block_passwd is unfortunately named so while converting block_passwd to QAPI,
> introduce a more properly named alias.
>
> Signed-off-by: Anthony Liguori <address@hidden>
I'm not sure if I like the set-blockdev-password alias, for two reasons.
The first one is that blockdev_* is supposed to be the new, clean
interface, so I wouldn't add similarly named commands without having a
look at the big picture. For example, what again was the reason for
having the password separate from other block device options?
The second one is that names like set-foo, get-foo and frob-foo make it
very hard to see what I can do with a foo. If they are called as today
(drive_add, drive_del) and ideally use a consistent prefix (unlike
drive_*, block_*, snapshot_blkdev today), you'll find all of them in the
same place in the documentation and in HMP typing blockdev_<TAB> will
show you everything you can do with a block device.
Kevin
- Re: [Qemu-devel] [PATCH 11/14] qapi: add change-vnc-listen, (continued)
[Qemu-devel] [PATCH 02/14] qapi: add code generation support for middle mode, Anthony Liguori, 2011/08/24
[Qemu-devel] [PATCH 09/14] qapi: convert block_passwd and add set-blockdev-password, Anthony Liguori, 2011/08/24
- Re: [Qemu-devel] [PATCH 09/14] qapi: convert block_passwd and add set-blockdev-password,
Kevin Wolf <=
[Qemu-devel] [PATCH 04/14] qapi: convert query-name, Anthony Liguori, 2011/08/24
[Qemu-devel] [PATCH 10/14] qapi: add change-vnc-password, Anthony Liguori, 2011/08/24
[Qemu-devel] [PATCH 14/14] vnc: don't demote authentication protocol when disabling login, Anthony Liguori, 2011/08/24