[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields |
Date: |
Thu, 25 Aug 2011 15:32:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-08-25 15:28, Anthony Liguori wrote:
> On 08/25/2011 08:13 AM, Jan Kiszka wrote:
>> On 2011-08-25 15:06, Anthony Liguori wrote:
>>> On 08/25/2011 07:38 AM, Jan Kiszka wrote:
>>>> On 2011-08-25 14:02, TeLeMan wrote:
>>>>> On Thu, Aug 25, 2011 at 19:04, Jan Kiszka<address@hidden> wrote:
>>>>>> What a mess. Do we really have to go through all 257 packed data
>>>>>> structs
>>>>>> in QEMU and add these MS compat bits to all potentially affected
>>>>>> ones?
>>>>> I prefer to detect -mms-bitfields and remove it in configure.
>>>>
>>>> /me too - if that is possible, ie. if the glib bits we are using
>>>> doesn't
>>>> require us to apply that mode. Can anyone comment on this?
>>>
>>> So why can't we just #pragma guard all of the slirp bits? Why are we
>>> doing it on a per data structure basis?
>>
>> Packing all structs is not really a good idea, more a last resort.
>
> It doesn't force packing, it forces GCC style structure layout.
If we are talking about #pragma pack(...), then that's not what I read
in the docs.
Jan
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, (continued)
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Anthony Liguori, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Jan Kiszka, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Avi Kivity, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Peter Maydell, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Avi Kivity, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Anthony Liguori, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields,
Jan Kiszka <=
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Stefan Weil, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Anthony Liguori, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Jan Kiszka, 2011/08/25
Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Blue Swirl, 2011/08/21