[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Probe HPET existence
From: |
Kevin O'Connor |
Subject: |
Re: [Qemu-devel] [PATCH] Probe HPET existence |
Date: |
Mon, 29 Aug 2011 20:35:45 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Aug 29, 2011 at 05:50:10PM +0200, Jan Kiszka wrote:
> QEMU does not provide a HPET block if it was configured with -no-hpet,
> other machines SeaBIOS runs on may lack a HPET as well. Perform basic
> checks the ID register for a reasonable vendor ID and a clock period
> within the valid range, do not build the HPET table if that fails.
It looks okay to me.
BTW, any particular reason to use 0x05F5E100 instead of 100000000?
-Kevin