[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Add support for r6040 NIC
From: |
bifferos |
Subject: |
Re: [Qemu-devel] [PATCH] Add support for r6040 NIC |
Date: |
Wed, 31 Aug 2011 14:35:45 +0100 (BST) |
--- On Wed, 31/8/11, malc <address@hidden> wrote:
> From: malc <address@hidden>
> Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC
> To: "Anthony Liguori" <address@hidden>
> Cc: address@hidden, "bifferos" <address@hidden>
> Date: Wednesday, 31 August, 2011, 14:17
> On Tue, 30 Aug 2011, Anthony Liguori
> wrote:
>
> > On 08/30/2011 08:30 PM, malc wrote:
> > > On Tue, 30 Aug 2011, Anthony Liguori wrote:
> > >
> > > > This won't even come close to passing
> checkpatch.pl
> > >
> > > Have you actually tried?
> >
> > Sigh. I was hoping checkpatch.pl was more useful
> than it appears to be.
> >
> > At any rate, the patch doesn't follow CODING_STYLE.
> >
>
> Where?
My apologies, actually I had a half-hearted look for the coding style, came to
this link:
http://git.qemu.org/qemu.git/plain/CODING_STYLE
Which was dead, and then fell back on the checkpatch.pl script, thinking nobody
cared so much about coding styles. I should have looked a bit more carefully.
Since then I found this:
http://git.savannah.gnu.org/cgit/qemu.git/tree/CODING_STYLE
AFAICS the problem is with the naming (part 3), which I can correct tonight
(along with the other issues raised)
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, (continued)
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Edgar E. Iglesias, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Anthony Liguori, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Edgar E. Iglesias, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Edgar E. Iglesias, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Anthony Liguori, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Blue Swirl, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Blue Swirl, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Edgar E. Iglesias, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Blue Swirl, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, bifferos, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC,
bifferos <=
- [Qemu-devel] [PATCH v2] Add support for r6040 NIC, bifferos, 2011/08/31