[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC
Date: Thu, 01 Sep 2011 12:42:55 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110805 Red Hat/3.1.12-1.el6_1 Thunderbird/3.1.12

On 08/31/11 18:06, Anthony Liguori wrote:
On 08/31/2011 09:35 AM, malc wrote:
On Wed, 31 Aug 2011, Anthony Liguori wrote:

Upper case field names are not okay. If you think coding style isn't
that's a bug in coding style.

There's no benefit to going through and changing existing code but new
code needs to be consistent with the vast majority of code in the rest
of the tree. It's about overall code base consistency and maintainability.

I don't see the point in being too picky about this. Especially consistency is a tricky thing.

As USB has been raised in this thread already: The struct field names in the USBDesc* structs are actually consistent. They are consistent with the naming convention in the USB world, i.e. you'll find those funky names like "wMaxPacketSize" in the USB specs, in the "lsusb -v" output and probably other places too. Which makes alot of sense IMHO and is quite convenient when hacking the USB code.

The USB naming convention and the qemu naming convention don't match, so it is impossible to please everybody here ...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]