[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] build: sort objects to remove duplicates for li

From: Lluís Vilanova
Subject: Re: [Qemu-devel] [PATCH] build: sort objects to remove duplicates for link
Date: Thu, 01 Sep 2011 21:47:59 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)

Anthony Liguori writes:

> On 08/25/2011 03:18 AM, Stefan Hajnoczi wrote:
>> Avoid duplicate object files during the link.  There are legitimate
>> cases where a link command-line would include duplicate object files
>> because two independent subsystems both depend on common infrastructure.
>> Use GNU make's $(sort) function to remove duplicate object files from
>> the link command-line.
>> Signed-off-by: Stefan Hajnoczi<address@hidden>

> Applied.  Thanks.

> Regards,

AFAIK, this patch is unnecessary once commit
e03b41d47708744669aaa51e781021c3dc380198 in Stefan's repo is merged into
upstream (which, according to the list, you just pulled).

The reason is that $(sort) is unnecessary when passing $^ to the LINK
function ($^ already eliminates repeats, while keeping the order
intact). The patch fixes the QEMU_PROG rule, which was the only one not
using $^.


 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom

reply via email to

[Prev in Thread] Current Thread [Next in Thread]