[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA |
Date: |
Fri, 2 Sep 2011 10:39:16 +1000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Sep 01, 2011 at 06:35:51PM +0300, Michael S. Tsirkin wrote:
> On Thu, Sep 01, 2011 at 03:00:54PM +1000, David Gibson wrote:
[snip]
> > +DECLARE_LDST_DMA(ub, b, 8);
> > +DECLARE_LDST_DMA(uw, w, 16);
> > +DECLARE_LDST_DMA(l, l, 32);
> > +DECLARE_LDST_DMA(q, q, 64);
> > +
> > +#undef DECLARE_LDST_DMA
> > +
> > #endif
>
> I'd prefer the stubs to be inline. Not just as an optimization:
> it also makes it easier to grok what goes on in the common
> no-iommu case.
So would I, but that doesn't work because of the poisonong of the phys
access functions.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
- [Qemu-devel] [0/10] Preliminary work for IOMMU emulation support; the easy bits, David Gibson, 2011/09/01
- [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA, David Gibson, 2011/09/01
- Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA, Anthony Liguori, 2011/09/01
- Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA, Avi Kivity, 2011/09/01
- Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA, Anthony Liguori, 2011/09/01
- Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA, Avi Kivity, 2011/09/01
- Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA, Anthony Liguori, 2011/09/01
- Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA, Avi Kivity, 2011/09/02
- Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA, Blue Swirl, 2011/09/03
- Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA, David Gibson, 2011/09/01