[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 42/45] block: Reset buffer alignment on detac

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 42/45] block: Reset buffer alignment on detach
Date: Fri, 02 Sep 2011 17:32:59 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Kevin Wolf <address@hidden> writes:

> Am 03.08.2011 15:08, schrieb Markus Armbruster:
>> BlockDriverState member buffer_alignment is initially 512.  The device
>> model may set them, with bdrv_set_buffer_alignment().  If the device
>> model gets detached (hot unplug), the device's alignment is left
>> behind.  Only okay because device hot unplug automatically destroys
>> the BlockDriverState.  But that's a questionable feature, best not to
>> rely on it.
>> Signed-off-by: Markus Armbruster <address@hidden>
> Hm, I'm not sure about this... Maybe instead of doing it on open and
> detach, which is a strange combination, the right thing would be to do
> it on attach?

Maybe.  My readiness to rearrange code for neatness declines a bit
beyond PATCH#30 or so ;)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]