[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386

From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386
Date: Sun, 4 Sep 2011 15:31:04 +0200

Am 03.09.2011 um 22:09 schrieb Anthony Liguori:

On 09/03/2011 08:44 AM, Andreas Färber wrote:
Am 02.09.2011 um 17:40 schrieb Anthony Liguori:

On 08/29/2011 09:55 AM, Anthony Liguori wrote:
diff --git a/Makefile.target b/Makefile.target
index 07af4d4..29287ed 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -27,12 +27,8 @@ ifdef CONFIG_USER_ONLY
# system emulator name
-ifeq ($(TARGET_ARCH), i386)


This will leave an old qemu executable from a previous `make install`

You're not supposed to do a make install on top of another install. You're supposed to first do a make uninstall in the old tree than a make install in the new tree.

In practice though, I do git pull, make, make install and so will others.

We should check for it and, unless it's a symlink to qemu-system- i386,
remove it in the install target.

Once we're no longer generating an executable, we should be removing it from the system.

It's up to the user to remove old files from the system.

Yeah, Paolo is right there, install shouldn't remove.

What I had in mind was Git's switch from lots of git-* scripts to the single git. `make install` checked for such artefacts. My point was, I believe we should do the same here and *detect* it within the install target. I'd be fine with a prominent textual notice. And I'd contribute a patch myself but have more urgent worries first, so if someone with more shell foo wants to take a stab, please do.

We should also make sure `make clean` still removes an old qemu from the build dir.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]