[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path
Date: Tue, 06 Sep 2011 10:46:50 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0

On 09/05/2011 10:36 PM, Blue Swirl wrote:
>  I don't agree. That's not what qemu_irq represents.
>  It represents a wire, a mechanism to drive changes through logic paths
>  between state. It is intrinsically stateless.
>  It may be the case that it is missused in some places, or that it isn't
>  always the best thing to use to represent what ever you need to represent,
>  so that you want to complement with other mechanisms.
>  But universally replacing it with a stateful alternative seems wrong to me.

Maybe there could be a stateless version of Pin for optimization:
Line? This would probably save one bool worth of memory and one memory
store access for each IRQ event.

Let's actually measure the effect of the bool/store before we optimize it away.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]