[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_ad

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch
Date: Wed, 07 Sep 2011 17:26:00 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0

On 09/07/2011 04:53 PM, Anthony Liguori wrote:

Long term, we use GIOChannels for everything, assuming that's possible
at all. More realistically, we could rewrite socket handling on Windows
so that we can use g_poll instead of select (don't wait for me doing

I assume switching to GIO would resolve all of these issues?


Another possibility, the ugliest but also the most realistic, is to
separate the Windows and POSIX implementations of the main loop more
sharply. This way glib's main loop can be integrated (differently) into
both implementations.

In the meanwhile: just do not rely on glib sources on Windows. There
isn't any large benefit in this patch, and it actually complicates the
straightforward code in iohandler. Just revert it and #ifdef the glib
integration in patch 1/2. Since I don't see a 100%-glib main loop
anytime soon, we are unlikely to lose much. If anybody introduces a
feature that requires Avahi or GTK+, it won't be supported on Windows.

My main motivation is unit testing.  I want to be able to have device
models only rely on glib main loop primitives such that we can easily
use devices in a simple glib main loop.

The split main loop approach won't work for that.

What if you extract the QEMU main loop to common code, and use it in the tests? Sounds not hard at all with iothread.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]