[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 5/8] configure: Avoid duplicate flags when calling c

From: Stefan Hajnoczi
Subject: [Qemu-devel] [PATCH 5/8] configure: Avoid duplicate flags when calling compile_prog
Date: Fri, 9 Sep 2011 10:24:12 +0100

From: Stefan Weil <address@hidden>

This patch removes redundant shell code and cleans it a little bit.

Shell macro compile_prog takes two arguments:
local_cflags and local ldflags.

$QEMU_CFLAGS is added automatically to the cflags, so there is no need
to pass it as an argument.

It is also unnecessary to pass -Werror twice.

$flag is a compiler warning option, so it should be in local_cflags
instead of local_ldflags.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index f808f48..348f36a 100755
--- a/configure
+++ b/configure
@@ -1070,7 +1070,7 @@ cat > $TMPC << EOF
 int main(void) { return 0; }
 for flag in $gcc_flags; do
-    if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then
+    if compile_prog "$flag -Werror" "" ; then
        QEMU_CFLAGS="$QEMU_CFLAGS $flag"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]