[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Remove blanks before \n in output strings

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] Remove blanks before \n in output strings
Date: Mon, 12 Sep 2011 21:48:00 +0100

On 12 September 2011 21:33, Stefan Weil <address@hidden> wrote:
> Those blanks violate the coding conventions, see
> scripts/checkpatch.pl.

I can see doing this if there are any cases of actual
output-to-users here, but for debug printfs, it scarcely
seems worth the effort. I'm not arguing against this particular
patch, since you've done the work now; just wondering what the
motivation was...

> diff --git a/tests/test-i386.c b/tests/test-i386.c
> index 9cb5b51..8e64bba 100644
> --- a/tests/test-i386.c
> +++ b/tests/test-i386.c
> @@ -802,7 +802,7 @@ void test_fcmp(double a, double b)
>         "fstsw %%ax\n"
>         : "=a" (fpus)
>         : "t" (a), "u" (b));
> -    printf("fcom(%f %f)=%04lx \n",
> +    printf("fcom(%f %f)=%04lx\n",
>            a, b, fpus & (0x4500 | FPUS_EMASK));
>     fpu_clear_exceptions();
>     asm("fucom %2\n"

(To save anybody else checking) Changing the output of this test
program is OK because tests/Makefile makes the arguable assumption
that we're running on an x86 box and can regenerate the "known good"
output reference rather than having to keep a copy in git...

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]