[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] Memory API mutators

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 0/3] Memory API mutators
Date: Wed, 14 Sep 2011 12:49:40 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0

Jan, too, was interested in this.

On 09/14/2011 12:23 PM, Avi Kivity wrote:
This patchset introduces memory_region_set_enabled() and
memory_region_set_address() to avoid the requirement on memory
routers to track the internal state of the memory API (so they know
whether they need to add or remove a region).  Instead, they can
simply copy the state of the region from the guest-exposed register
to the memory core, via the new mutator functions.

Please review.  Do we need a memory_region_set_size() as well?  Do we want

                                MR_ATTR_ENABLED | MR_ATTR_SIZE,
                                (MemoryRegionAttributes) {
                                    .enabled = s->enabled,
                                    .address = s->addr,


Avi Kivity (3):
   memory: introduce memory_region_set_enabled()
   memory: introduce memory_region_set_address()
   memory: optimize empty transactions due to mutators

  memory.c |   64 ++++++++++++++++++++++++++++++++++++++++++++++++++++---------
  memory.h |   28 +++++++++++++++++++++++++++
  2 files changed, 82 insertions(+), 10 deletions(-)

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]