[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] memory: simple memory tree printer
Date: Wed, 14 Sep 2011 18:29:35 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0

On 09/14/2011 06:27 PM, Richard Henderson wrote:
On 09/14/2011 08:23 AM, Avi Kivity wrote:
>  On 09/14/2011 06:10 PM, Richard Henderson wrote:
>>  >
>>  >   So the default address passed to the handler is now already relative? I
>>  >   think we should keep it like this for all converted devices, ie. take
>>  >   the chance, fix the remaining models, and drop the offset.
>>  It's non-zero for the isa portio conversion that I did, which
>>  I thought was in Avi's tree.
>  That's MemoryRegionPortio::offset, not MemoryRegion::offset.

No, look in isa_register_portio_list:

         memory_region_init_io(region, ops, opaque, name, off_high - off_low);
         memory_region_set_offset(region, start + off_low);

That last line sets MemoryRegion::offset.

That's not in my queue.  Which patchset was that?

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]