[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size
Date: Thu, 15 Sep 2011 09:36:08 +0100

On 15 September 2011 08:33, Gerd Hoffmann <address@hidden> wrote:
> On 09/14/11 19:48, Peter Maydell wrote:
>> Honour the maximum packet size for endpoints; this applies when
>> sending non-isochronous data and means we transfer only as
>> much as the endpoint allows, leaving the transfer descriptor
>> on the list for another go next time around. This allows
>> usb-net to work when connected to an OHCI controller model.
> Hmm, I'd tend to fix it the other way around:  Fix usb-net to deal with
> transfers larger than the endpoint packet size.  What do you think?

Honouring maximum packet size is mandated by the OHCI spec:
see section "Packet Size" in OHCI specification 1.0a.
Our failure to do it is just a bug in our controller model.

If you want to make our usb-net implementation permit and
advertise a larger max-packet-size (and test it for
interoperability with a pile of OSes :-)) that's a different

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]