qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: Make missing pkg-config an error rat


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] configure: Make missing pkg-config an error rather than a warning
Date: Thu, 15 Sep 2011 14:08:20 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2

On 09/15/2011 01:15 PM, Peter Maydell wrote:
If pkg-config doesn't exist then make configure fail immediately
with a useful error message. Now that glib is a required dependency,
proceeding despite the missing pkg-config will just cause us to
fail later with a misleading message about glib not being present.

Signed-off-by: Peter Maydell<address@hidden>
---
  configure |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 0875f95..6c2839d 100755
--- a/configure
+++ b/configure
@@ -1339,8 +1339,8 @@ fi
  # pkg-config probe

  if ! has $pkg_config; then
-  echo warning: proceeding without "$pkg_config">&2
-  pkg_config=/bin/false
+  echo "Error: pkg-config binary '$pkg_config' not found"
+  exit 1
  fi

  ##########################################

Acked-by: Paolo Bonzini <address@hidden>

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]