[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Add astyle option file for code formatting

From: Stefan Weil
Subject: Re: [Qemu-devel] [PATCH] Add astyle option file for code formatting
Date: Fri, 16 Sep 2011 16:31:18 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20110831 Thunderbird/3.1.13

Am 16.09.2011 15:07, schrieb Anthony Liguori:
On 09/11/2011 12:00 PM, Stefan Weil wrote:
For new C code (and maybe also for existing code), a code formatter
like Artistic Style is helpful because it can fix tabs, indentation
and other style issues.

This option file tries to set astyle options which match QEMU's
coding conventions.

The quality of astyle's code formatting depends on the astyle version
(I got best results with newer versions) and on the code which is going
to be formatted.

For some code, formatting of brackets and operators does not work well.
Fixing indentation and tabs always worked well for me.

Signed-off-by: Stefan Weil<address@hidden>
  scripts/astylerc |   16 ++++++++++++++++
  1 files changed, 16 insertions(+), 0 deletions(-)
  create mode 100644 scripts/astylerc

Please put a copyright in this file.

FWIW, this is what I use with emacs:

(c-add-style "qemu"
                (indent-tabs-mode . nil)
                (c-basic-offset   . 4)
                (tab-width . 8)
        nil) ; t = set this style, nil = don't


Anthony Liguori

Are you sure that you want a copyright even for simple configuration
files like this one? I don't think this file could be copyrighted in
my country because it is too simple.

There are more complex files in scripts without any copyright:


If it is common understanding that every file should have a copyright,
this rule should be added to CODING_STYLE.

I don't mind adding a line "# public domain", nor do I mind if it
is committed as it is.

Stefan Weil

PS. It might help some people if you would commit your emacs style, too.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]