[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/18] omap_gpmc: GPMC_IRQSTATUS is write-one
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 07/18] omap_gpmc: GPMC_IRQSTATUS is write-one-to-clear |
|
Date: |
Sat, 17 Sep 2011 16:47:32 +0100 |
On 17 September 2011 02:08, andrzej zaborowski <address@hidden> wrote:
>> --- a/hw/omap_gpmc.c
>> +++ b/hw/omap_gpmc.c
>> @@ -284,7 +284,7 @@ static void omap_gpmc_write(void *opaque,
>> target_phys_addr_t addr,
>> break;
>>
>> case 0x018: /* GPMC_IRQSTATUS */
>> - s->irqen = ~value;
>> + s->irqen &= ~value;
>
> Should we be clearing s->irqst here instead of irqen?
Oops, you're right... (IIRC this change was a spotted-while-reading-code
one, not a response to a behavioural issue with the model.)
-- PMM