[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] sun4u: don't set up isa_mem_base

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] sun4u: don't set up isa_mem_base
Date: Sun, 18 Sep 2011 14:30:43 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2

On 09/17/2011 10:28 PM, Blue Swirl wrote:
Since we use memory API in sun4u.c, after
71579cae30b53c910cd6c47ab4e683f647d36519, setting up isa_mem_base
puts vga.chain4 outside of the physical address space.

Fix by removing obsolete isa_mem_base set up.

Signed-off-by: Blue Swirl<address@hidden>
  hw/sun4u.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/hw/sun4u.c b/hw/sun4u.c
index 32e6ab9..6afb0e7 100644
--- a/hw/sun4u.c
+++ b/hw/sun4u.c
@@ -763,7 +763,6 @@ static void sun4uv_init(ram_addr_t RAM_size,
      irq = qemu_allocate_irqs(cpu_set_irq, env, MAX_PILS);
      pci_bus = pci_apb_init(APB_SPECIAL_BASE, APB_MEM_BASE, irq,&pci_bus2,
-    isa_mem_base = APB_PCI_IO_BASE;

Good catch, I wonder how many more such cases remain.

I guess we should prioritize their conversion.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]