[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/11] ISA bus improvements

From: Hervé Poussineau
Subject: Re: [Qemu-devel] [PATCH 00/11] ISA bus improvements
Date: Sun, 18 Sep 2011 21:33:38 +0200
User-agent: Thunderbird (Windows/20090812)

Jan Kiszka a écrit :
On 2011-09-18 16:56, Hervé Poussineau wrote:
Following patches aim to change ISA bus to a first-citizen class in Qemu.

They add ISA bus ops, like for scsi and usb buses.

Current ISA bridges (PIIX3, PIIX4, EBUS and VT82C686) are converted
to this new API, and a simple 'isabus-bridge' device is added.

isa_address_space() operation can probably be used to remove the
infamous isa_mem_base variable. However, some work is already done
in this direction on the ML, so I didn't change anything.

Finally, add bus argument to isa_create() functions, so architectures
with multiple ISA buses (like some Alpha systems) can be emulated.

As RFC didn't receive much comments, I put this serie as patches.

Nice work. I had something similar unfinished here, but this one looks
better on first glace.


Still, I would go one step further and kill the global default isa_bus:
all ISA API user should pass in the bus they created and obtained from
some creator.

That's indeed the next step I have in mind.
It shouldn't be hard to do; that's mostly adding an isa_bus parameter in all functions from ISA bridge creation to all ISA devices. However, lots of prototypes will probably have to be changed, so I wanted to do it in a second patchset.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]