[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_off

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] isa: Avoid using obsolete memory_region_set_offset for old portio
Date: Mon, 19 Sep 2011 15:15:51 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2

On 09/18/2011 10:16 PM, Jan Kiszka wrote:
On 2011-09-18 18:49, Richard Henderson wrote:
>  On 09/18/2011 05:54 AM, Jan Kiszka wrote:
>>  @@ -375,8 +375,7 @@ static const MemoryRegionPortio 
*find_portio(MemoryRegion *mr, uint64_t offset,
>>       const MemoryRegionPortio *mrp;
>>       for (mrp = mr->ops->old_portio; mrp->size; ++mrp) {
>>  -        if (offset>= mrp->offset&&  offset<  mrp->offset + mrp->len
>>  -&&  width == mrp->size
>>  +        if (offset<  mrp->len&&  width == mrp->size
>  This change looks broken to me.  How, exactly, are you
>  disambiguating different entries?

See my reply to Avi: all offsets of an portio region must be the same.

Said Avi doesn't understand.  VGA for example has many ports.

Or are you saying, split the input into sets of discontinuous ports, within each set you can use only one offset?

They should actually only differ in access width, but there is still at
least one counter example (of course IDE...). Given that this is just a
portability helper, all this will likely be reviewed and cleaned up when
getting rid of old portio.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]