[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts
Date: Mon, 19 Sep 2011 15:22:21 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2

On 09/18/2011 10:07 PM, Jan Kiszka wrote:
>  I don't think it should be deduplicated.  The device is providing two
>  separate ABIs.

Yes, two ABIs, and the only difference is the offset of the data register.

How about

#ifdef TARGET_I386
# define VBE_DATA_REG 1
# define VBE_DATA_REG 2

>  Why disallow it?

Did anyone check that something useful or at least valid comes out of
the handlers when doing this so far impossible access?

It's a general problem. It can't be fixed in devices, the core has to handle this (and devices have to tell it how to react to such accesses).

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]