[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] trace: [ust] Do not use 'm' in event argume

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 2/3] trace: [ust] Do not use 'm' in event argument names (used by ust macros)
Date: Tue, 20 Sep 2011 12:52:02 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
>  trace-events |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> diff --git a/trace-events b/trace-events
> index 9d1fbbb..b653d70 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -418,8 +418,8 @@ milkymist_pfpu_pulse_irq(void) "Pulse IRQ"
>  # hw/milkymist-softusb.c
>  milkymist_softusb_memory_read(uint32_t addr, uint32_t value) "addr %08x 
> value %08x"
>  milkymist_softusb_memory_write(uint32_t addr, uint32_t value) "addr %08x 
> value %08x"
> -milkymist_softusb_mevt(uint8_t m) "m %d"
> -milkymist_softusb_kevt(uint8_t m) "m %d"
> +milkymist_softusb_mevt(uint8_t _m) "m %d"
> +milkymist_softusb_kevt(uint8_t _m) "m %d"

The LTTng community has been very responsive in addressing namespace
issues with libust.  Let's post more details and see if it can be fixed
in libust.

Could you please post your gcc and libust versions?

I have not been able to reproduce the problem on Debian libust-dev
0.15-3.  My gcc version is Debian gcc 4.6.1-4.

Here is the test program:

#include <stdint.h>
#include <ust/tracepoint.h>

DECLARE_TRACE(ust_milkymist_softusb_mevt, TP_PROTO(uint8_t m),

int main(int argc, char **argv)
        return 0;

I see no warning or error related to the 'm' argument name.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]