[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ahci: add port I/O index-data pair

From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH] ahci: add port I/O index-data pair
Date: Tue, 20 Sep 2011 16:02:01 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110221 SUSE/3.1.8 Thunderbird/3.1.8

On 09/20/2011 03:39 PM, Kevin Wolf wrote:
Am 28.08.2011 20:48, schrieb Alexander Graf:
On 27.08.2011, at 04:12, Daniel Verkamp wrote:

Implement an I/O space index-data register pair as defined by the AHCI
spec, including the corresponding SATA PCI capability and BAR.

This allows real-mode code to access the AHCI registers; real-mode
code cannot address the memory-mapped register space because it is
beyond the first megabyte.
Very nice patch! I'll check and compare with a real ICH-9 when I get back to 
.de, but I'd assume you also did that already ;). Once I checked that the IO 
region is set up similarly, I'll give you my ack.
What's the status with review/testing of this patch, Alex? Is it ready
to be merged, should I drop it or do you just need some more time?

If you don't see regressions with it, I'd say we're good. I still don't have a validation program, but considering that it's a reasonably simple change and makes us more conforming to real hardware, I don't see why we shouldn't have it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]