[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Tree broken by nbd: support feature negotiation commit.

From: Brad
Subject: Re: [Qemu-devel] Tree broken by nbd: support feature negotiation commit.
Date: Wed, 21 Sep 2011 03:43:47 -0400
User-agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv: Gecko/20110902 Thunderbird/3.1.14

On 21/09/11 3:32 AM, Paolo Bonzini wrote:
On 09/21/2011 09:27 AM, Brad wrote:
Besides the obvious issue..

nbd.c:443: error: conflicting types for 'nbd_init'
nbd.h:71: error: previous declaration of 'nbd_init' was here

Oops, thanks for pointing it out to me.

The changing of #ifndef _WIN32 to #ifdef __linux__ in nbd.c also
looks questionable to me.

It is not portable code, and (unlike the rest of qemu-nbd and the
block/nbd.c protocol) not meant to be portable. Are BLKROSET (defined in
linux/fs.h) and the whole set of NBD ioctls available under OpenBSD?

Ok. What confused me a bit is that particular code path before your commit was being built on anything but Windows but is now Linux only.
No we don't have BLKROSET. So am I to understand that even before this
particular commit that this code was only supported on Linux? I honestly
have no familiarity with NBD.

This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]