[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] e1000: Don't set the Capabilities List bit

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] e1000: Don't set the Capabilities List bit
Date: Fri, 23 Sep 2011 11:06:30 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10

On 09/21/2011 03:06 PM, dann frazier wrote:
[Originally sent to qemu-kvm list, but I was redirected here]

The Capabilities Pointer is NULL, so this bit shouldn't be set. The state of
this bit doesn't appear to change any behavior on Linux/Windows versions we've
tested, but it does cause Windows' PCI/PCI Express Compliance Test to balk.

I happen to have a physical 82540EM controller, and it also sets the
Capabilities Bit, but it actually has items on the capabilities list to go
with it :)

Signed-off-by: dann frazier<address@hidden>

Applied.  Thanks.


Anthony Liguori

  hw/e1000.c |    2 --
  1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/hw/e1000.c b/hw/e1000.c
index 6a3a941..ce8fc8b 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1151,8 +1151,6 @@ static int pci_e1000_init(PCIDevice *pci_dev)

      pci_conf = d->dev.config;

-    /* TODO: we have no capabilities, so why is this bit set? */
-    pci_set_word(pci_conf + PCI_STATUS, PCI_STATUS_CAP_LIST);
      /* TODO: RST# value should be 0, PCI spec 6.2.4 */
      pci_conf[PCI_CACHE_LINE_SIZE] = 0x10;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]