[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium specific ins

From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium specific instructions
Date: Wed, 28 Sep 2011 10:29:18 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv: Gecko/20110907 SUSE/3.1.14 Thunderbird/3.1.14

Am 27.09.2011 06:17, schrieb address@hidden:
> From: Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt <address@hidden>
> Signed-off-by: Khansa Butt <address@hidden>

...nor all of mine from previous rounds. Including From vs.
Signed-off-by mixup (From is who sent the patch, not whom the code
originated from), Coding Style issues, misleading "Cavium specific"
comments, typos, ...

A space after the colon in the subject would be more visually pleasing, too.

Further, your patch series is completely missing versioning ([PATCH vX
n/m] and change log). Not seeing what you've actually changed for this
resubmission while still seeing unaddressed flaws we've pointed out
already becomes annoying after a while and will not help your patches
make it into the repository...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]