[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers

From: Jan Kiszka
Subject: Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers
Date: Wed, 28 Sep 2011 16:33:51 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv: Gecko/20080226 SUSE/ Thunderbird/ Mnenhy/

On 2011-09-28 16:26, Richard Henderson wrote:
On 09/28/2011 05:28 AM, Jan Kiszka wrote:
+    { INDEX_op_deposit8l_i32, { "r", "0", "r" } },
+    { INDEX_op_deposit8l_i32, { "abcd", "0", "abcd" } },

At minimum, abcd is spelled "q".

Ah, perfect.

I don't particularly care for the 3 different opcodes.  Perhaps
we'd be better off with an inline predicate for when the deposit
opcode is "valid"?

We still need to dispatch at tcg generation time which variant is valid. Or what do you have in mind?


Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

reply via email to

[Prev in Thread] Current Thread [Next in Thread]