|
| From: | Jan Kiszka |
| Subject: | Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset |
| Date: | Wed, 28 Sep 2011 23:18:03 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-09-28 20:01, Blue Swirl wrote:
On Wed, Sep 28, 2011 at 11:00 AM, Jan Kiszka<address@hidden> wrote:As we clearly modify the PIC state on pic_reset, we also have to update the IRQ output. This only happened on init so far. Apply this consistently.Nack, IRQ lines shouldn't be touched on reset. The other side may not be ready for receiving the interrupt change and qemu_irqs are stateless anyway.
Sorry, but failing to clear the line (this is what pic_update_irq will effectively do) is a clear bug in the current code. This patch is 100% analogue to what, e.g. the PCI layer does on reset. Please re-read.
Jan
| [Prev in Thread] | Current Thread | [Next in Thread] |