qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 00/21]: First round of QAPI conversions


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH v1 00/21]: First round of QAPI conversions
Date: Thu, 29 Sep 2011 07:55:37 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 09/28/2011 09:44 AM, Luiz Capitulino wrote:
This series is a bundle of three things:

  1. Patches 01 to 04 add the middle mode feature to the current QMP server.
     That mode allows for the current server to support QAPI commands. The
     Original author is Anthony, you can find his original post here:

         http://lists.gnu.org/archive/html/qemu-devel/2011-09/msg00374.html

  2. Patches 05 to 10 are fixes from Anthony and Michael to the QAPI
     handling of the list type.

  3. Patches 11 to 21 are simple monitor commands conversions to the QAPI.
     This is just a rebase of a previous conversion work by Anthony.

Great series!

Other than the one minor comment re: strdup and commit messages, I think it's ready to go.

Regards,

Anthony Liguori


  Makefile                    |   12 ++
  Makefile.objs               |    3 +
  Makefile.target             |    6 +-
  error.c                     |    4 +
  hmp-commands.hx             |   11 +-
  hmp.c                       |  116 ++++++++++++++++++
  hmp.h                       |   31 +++++
  monitor.c                   |  273 +++++--------------------------------------
  qapi-schema.json            |  273 +++++++++++++++++++++++++++++++++++++++++++
  qapi/qapi-dealloc-visitor.c |   34 +++++-
  qapi/qapi-types-core.h      |    3 +
  qapi/qmp-input-visitor.c    |    4 +-
  qapi/qmp-output-visitor.c   |   20 +++-
  qemu-char.c                 |   35 ++----
  qerror.c                    |   33 +++++
  qerror.h                    |    2 +
  qmp-commands.hx             |   57 +++++++--
  qmp.c                       |   92 +++++++++++++++
  scripts/qapi-commands.py    |   98 ++++++++++++---
  scripts/qapi-types.py       |    5 +
  scripts/qapi-visit.py       |    4 +-
  scripts/qapi.py             |    4 +-
  test-qmp-commands.c         |   29 +++++
  test-visitor.c              |   48 +++++++--
  vl.c                        |   12 ++
  25 files changed, 877 insertions(+), 332 deletions(-)






reply via email to

[Prev in Thread] Current Thread [Next in Thread]