Re: [Qemu-devel] [PATCH 3/3] Delayed IP packets

[Jan Kiszka]

On 2011-09-29 19:50, Amit Shah wrote:
> On (Thu) 29 Sep 2011 [19:41:33], Jan Kiszka wrote:
>> On 2011-09-29 18:06, Amit Shah wrote:
>>> On (Wed) 03 Aug 2011 [13:24:22], Jan Kiszka wrote:
>>>> From: Fabien Chouteau <address@hidden>
>>>>
>>>> In the current implementation, if Slirp tries to send an IP packet to a 
>>>> client
>>>> with an unknown hardware address, the packet is simply dropped and an ARP
>>>> request is sent (if_encap in slirp/slirp.c).
>>>>
>>>> With this patch, Slirp will send the ARP request, re-queue the packet and 
>>>> try
>>>> to send it later. The packet is dropped after one second if the ARP reply 
>>>> is
>>>> not received.
>>>
>>> This patch causes a segfault when guests wake up from hibernate.
>>>
>>> Recipe:
>>> 1. Start guest with -net user -net nic,model=virtio
>>> 2. (guest) ping 10.0.2.2
>>> 3. (guest) echo "disk" > /sys/power/state
>>> 4. Re-start guest with same command line
>>> 5. Ping has stopped receiving replies.
>>> 6. Kill that ping process and start a new one.  qemu segfaults.
>>
>> Can't reproduce, I'm not getting stable hibernation here even without
>> any network configured.
> 
> With virtio devices and the patches applied?  Can you tell me what
> you're seeing?

No, I didn't patch my guest. I was using standard IDE with an emulated
NIC (or without) against a 3.1-rc3 (or so) guest.

> 
>> Could you check if the recent pull request [1] changes the picture for you?
> 
> Thanks, that series fixes the problem.

Perfect! Right in time. :)

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux