qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_p


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte()
Date: Thu, 06 Oct 2011 18:26:15 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2

On 10/06/2011 06:21 PM, Juan Quintela wrote:
+    result = qemu_peek_byte(f);
+
+    if (f->buf_index<  f->buf_size) {
+        f->buf_index++;
      }

This should really be an assert that f->buf_index < f->buf_size, otherwise qemu_peek_byte has read garbage.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]