Re: [Qemu-devel] [PATCH] tcg: Introduce TCGReg for all TCG hosts (fixes build for s390 hosts)

[Blue Swirl]

On Fri, Oct 7, 2011 at 6:26 PM, Stefan Weil <address@hidden> wrote:
> Am 07.10.2011 20:13, schrieb Richard Henderson:
>>
>> On 10/07/2011 11:00 AM, Stefan Weil wrote:
>>>
>>> +#define TCGReg int /* TODO: Remove this line when tcg-target.c uses
>>> TCGReg. */
>>
>> Nack. This is too ugly to live.

Fully agree.

>>
>> How hard can it be to simply change the prototype in each
>> of the backend files instead? Yes, full conversion to
>> TCGReg is desirable, but this is not C++ -- integers and
>> enums are interchangable without casts.
>>
>> r~
>
> The goal of my patch is to get code which compiles again
> on all hosts with minimum risk and which is a base for further
> improvements.
>
> I cannot run build tests for all possible hosts, and even
> changing 4 prototypes for each host is a risk when it is not
> tested. Yes, you can review the changes, some developers can
> try builds, but that takes a lot of time.

The only problem with changing ints to enums is that enums may be
unsigned depending on the compiler, otherwise it is safe. I don't
think any arithmetic is performed with the register numbers.

> As soon as my patch is applied, it is possible to add
> more TCGReg usage to tcg.c, s390/tcg-target.c and all
> other TCG targets in independent patches.
>
> I'm just preparing patches for tcg.c and i386/tcg-target.*.
>
> But let me repeat: these new patches need a good review
> which will take some time. The bug fix should be applied soon.
> Maybe you can change your mind and send an ack.
>
> - Stefan
>
>