Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA

[David Gibson]

On Wed, Oct 12, 2011 at 09:22:01AM +0200, Michael S. Tsirkin wrote:
> On Wed, Oct 12, 2011 at 02:07:46PM +1100, David Gibson wrote:
> > Um.. why?  PCI is defined by the spec to be LE, so I don't see that we
> > need explicit endianness versions for PCI helpers.
> 
> LE in the spec only applies to structures defined by the spec,
> that is pci configuration and msix tables in device memory.

Well, true.  But when was the last time you saw a PCI device with BE
registers?  I think it's a rare enough case that the individual device
models can reswap themselves.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson