Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

[Paolo Bonzini]

On 10/14/2011 04:02 PM, Kevin Wolf wrote:
> > >
> > >  It would still host the checks on BDRV_O_NO_FLUSH and bs->drv->*_flush.
> > >     It would be the same as bdrv_flush_co_entry is now, minus the
> > >  marshalling in/out of the RwCo.
> Right.
>
> By the way, I like how you handle all three backends in the same
> function. I think this is a lot more readable than the solution used by
> read/write (changing the function pointers on driver registration).

Yeah, and it makes sense to handle all of them in the bdrv_co_* version.

Will resubmit.

Paolo