[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] PPC: Fail configure when libfdt is not availabl
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] PPC: Fail configure when libfdt is not available |
Date: |
Tue, 18 Oct 2011 10:47:35 +0100 |
On 18 October 2011 01:18, Alexander Graf <address@hidden> wrote:
> +if test "$fdt" != "yes" -a \( "$target_arch2" = "ppc" -o \
> + "$target_arch2" = "ppc64" -o "$target_arch2" = "ppcemb" \); then
> + echo
> + echo "Error: libfdt missing"
> + echo "The PowerPC target requires libfdt to work properly."
> + echo "Please make sure to have it and its development packages installed"
> + echo
> + exit 1
> +fi
> if test "$target_arch2" = "ppc64" -a "$fdt" = "yes"; then
> echo "CONFIG_PSERIES=y" >> $config_target_mak
> fi
The test -a, -o, ( and ) operators are deprecated (see the 'application
usage section' of the POSIX 'test' documentation:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
) -- better not to use them in new code.
Since target_arch2 == ppc64 and fdt != yes is now an impossible
combination, you could remove the fdt check from the condition
below which sets CONFIG_PSERIES.
Also, missing '.' after 'installed'.
-- PMM
- Re: [Qemu-devel] [PATCH] PPC: Fail configure when libfdt is not available, (continued)
Re: [Qemu-devel] [PATCH] PPC: Fail configure when libfdt is not available,
Peter Maydell <=