Re: [Qemu-devel] Patch for ui/cocoa.m

[Juan Pineda]

Hi Andreas,

Thanks for your quick reply. Regarding your questions:

>> What command line do you use? If using the right arguments you
>> shouldn't see a window at all. Are you maybe using -drive instead of
>> -hda and that is not yet handled correctly?

The boot volume dialog appears only when a hard disk file is not supplied on 
the command line. I would think the failure of the dialog to close is not 
unique to Lion. However in prior OS releases it probably does not present a 
problem as the main window can be raised above the dialog.

>> Apart from this issue, is it working correctly for you?


Yes and no. I am able to compile and run version 0.15.1 under Lion by 
specifying some flags in the configure phase. More information in my post to 
Qemu-devel here:

> http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg02020.html

With the specified flags, version 0.15.1 seems to run OK with my limited 
testing, although I have seen some segment violations using qemu-system-sparc 
trying to boot some Linux images.

However building the main branch (with flags as above) does not work. The build 
fails with error about redefinition of uint16 in fpu/softfloat.h. If that is 
fixed the build completes. But trying to run qemu-system-i386 quits:

> $ i386-softmmu/qemu-system-i386 -hda ~/Downloads/linux-0.2.img
> 
> GThread-ERROR **: GThread system may only be initialized once.
> aborting...
> Abort trap: 6


Building also displays many warning messages about redefinition of 
CONFIG_EMU_PREFIX. I'm running with OSX 10.7 and Xcode completely up to the 
latest revisions.

Thanks!
-Juan



On Oct 18, 2011, at 2:11 AM, Andreas Färber wrote:

> Hello Juan,
> 
> Am 18.10.2011 03:22, schrieb Juan Pineda:
>> This is my first time submitting a patch, so please let me know if I'm not 
>> following the correct protocol.
> 
> Please see http://wiki.qemu.org/Contribute/SubmitAPatch
> 
> Using the git-send-mail tool assures that the patch format gets right.
> 
> Then, this patch despite its small size is not "trivial" so instead of
> address@hidden please cc address@hidden for Cocoa. Thanks.
> 
>> Under OSX Lion the boot volume dialog is not closed and it permanently 
>> obscures the emulator window since under Lion the dialog cannot be 
>> repositioned. The fix adds only to add a single line to close the dialog.
> 
> I don't have access to v10.7 so please describe the problem in more
> details: What command line do you use? If using the right arguments you
> shouldn't see a window at all. Are you maybe using -drive instead of
> -hda and that is not yet handled correctly?
> 
> Apart from this issue, is it working correctly for you?
> 
> Regards,
> Andreas
> 
>> Signed-off-by: Juan Pineda <address@hidden>
>> 
>> Thanks!
>> -Juan
>> 
>> 
>>> git diff ui/cocoa.m
>> diff --git a/ui/cocoa.m b/ui/cocoa.m
>> index d9e4e3d..4b42462 100644
>> --- a/ui/cocoa.m
>> +++ b/ui/cocoa.m
>> @@ -811,6 +811,8 @@ QemuCocoaView *cocoaView;
>> 
>>         char **argv = (char**)malloc( sizeof(char*)*3 );
>> 
>> +       [sheet close];
>> +
>>         asprintf(&argv[0], "%s", bin);
>>         asprintf(&argv[1], "-hda");
>>         asprintf(&argv[2], "%s", img);
>> 
>> 
> 
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746, AG Nürnberg