Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

[ronnie sahlberg]

Hi,


On Tue, Oct 25, 2011 at 7:17 PM, Kevin Wolf <address@hidden> wrote:
> Am 25.10.2011 10:04, schrieb ronnie sahlberg:
>>> iscsi_destroy_url() is only ever called here. Do we leak it in the normal 
>>> path?
>>
>> It didnt leak but the the label was confusing. I have changed it from
>> "failed" to "finished" since this part
>> is executed for both normal and failures.
>
> But there's a return 0; immediately before the label?

Right. Its been a long day :-)

Please find attached a fixed version.


regards
ronnie sahlberg

>
> Kevin
>

0001-This-provides-built-in-support-for-iSCSI-to-QEMU.patch
Description: Text Data

0001-This-provides-built-in-support-for-iSCSI-to-QEMU.patch.gz
Description: GNU Zip compressed data