[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/8] qmp: add block_job_set_speed command
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 5/8] qmp: add block_job_set_speed command |
Date: |
Thu, 27 Oct 2011 16:22:52 +0100 |
Add block_job_set_speed, which sets the maximum speed for a background
block operation.
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
blockdev.c | 33 +++++++++++++++++++++++++++++++++
blockdev.h | 2 ++
hmp-commands.hx | 15 +++++++++++++++
qmp-commands.hx | 35 +++++++++++++++++++++++++++++++++++
4 files changed, 85 insertions(+), 0 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index de911de..781825b 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -851,3 +851,36 @@ int do_block_stream(Monitor *mon, const QDict *params,
QObject **ret_data)
trace_do_block_stream(bs, bs->job);
return 0;
}
+
+static BlockJob *find_block_job(const char *device)
+{
+ BlockDriverState *bs;
+
+ bs = bdrv_find(device);
+ if (!bs || !bs->job) {
+ return NULL;
+ }
+ return bs->job;
+}
+
+int do_block_job_set_speed(Monitor *mon, const QDict *params,
+ QObject **ret_data)
+{
+ const char *device = qdict_get_str(params, "device");
+ BlockJob *job = find_block_job(device);
+ int64_t value;
+ int ret;
+
+ if (!job) {
+ qerror_report(QERR_DEVICE_NOT_ACTIVE, device);
+ return -1;
+ }
+
+ value = qdict_get_int(params, "value");
+ ret = block_job_set_speed(job, value);
+ if (ret == -ENOTSUP) {
+ qerror_report(QERR_NOT_SUPPORTED);
+ return -1;
+ }
+ return 0;
+}
diff --git a/blockdev.h b/blockdev.h
index ad98d37..6b48405 100644
--- a/blockdev.h
+++ b/blockdev.h
@@ -66,5 +66,7 @@ int do_drive_del(Monitor *mon, const QDict *qdict, QObject
**ret_data);
int do_snapshot_blkdev(Monitor *mon, const QDict *qdict, QObject **ret_data);
int do_block_resize(Monitor *mon, const QDict *qdict, QObject **ret_data);
int do_block_stream(Monitor *mon, const QDict *qdict, QObject **ret_data);
+int do_block_job_set_speed(Monitor *mon, const QDict *qdict,
+ QObject **ret_data);
#endif
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 2aeb2e0..2cdfa0b 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -86,6 +86,21 @@ Copy data from a backing file into a block device.
ETEXI
{
+ .name = "block_job_set_speed",
+ .args_type = "device:B,value:o",
+ .params = "device value",
+ .help = "set maximum speed for a background block operation",
+ .user_print = monitor_user_noop,
+ .mhandler.cmd_new = do_block_job_set_speed,
+ },
+
+STEXI
address@hidden block_job_set_stream
address@hidden block_job_set_stream
+Set maximum speed for a background block operation.
+ETEXI
+
+ {
.name = "eject",
.args_type = "force:-f,device:B",
.params = "[-f] device",
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 31cde4b..6cfb548 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -750,6 +750,41 @@ Examples:
EQMP
{
+ .name = "block_job_set_speed",
+ .args_type = "device:B,value:o",
+ .params = "device value",
+ .user_print = monitor_user_noop,
+ .mhandler.cmd_new = do_block_job_set_speed,
+ },
+
+SQMP
+
+block_job_set_speed
+-------------------
+
+Set maximum speed for a background block operation.
+
+This command can only be issued when there is an active block job.
+
+Throttling can be disabled by setting the speed to 0.
+
+Arguments:
+
+- device: device name (json-string)
+- value: maximum speed, in bytes per second (json-int)
+
+Errors:
+NotSupported: job type does not support speed setting
+DeviceNotActive: streaming is not active on this device
+
+Example:
+
+-> { "execute": "block_job_set_speed",
+ "arguments": { "device": "virtio0", "value": 1024 } }
+
+EQMP
+
+ {
.name = "blockdev-snapshot-sync",
.args_type = "device:B,snapshot-file:s?,format:s?",
.params = "device [new-image-file] [format]",
--
1.7.7
- [Qemu-devel] [PATCH 0/8] block: generic image streaming, Stefan Hajnoczi, 2011/10/27
- [Qemu-devel] [PATCH 7/8] qmp: add query-block-jobs, Stefan Hajnoczi, 2011/10/27
- [Qemu-devel] [PATCH 8/8] test: add image streaming test cases, Stefan Hajnoczi, 2011/10/27
- [Qemu-devel] [PATCH 2/8] block: add BlockJob interface for long-running operations, Stefan Hajnoczi, 2011/10/27
- [Qemu-devel] [PATCH 4/8] qmp: add block_stream command, Stefan Hajnoczi, 2011/10/27
- [Qemu-devel] [PATCH 6/8] qmp: add block_job_cancel command, Stefan Hajnoczi, 2011/10/27
- [Qemu-devel] [PATCH 1/8] coroutine: add co_sleep_ns() coroutine sleep function, Stefan Hajnoczi, 2011/10/27
- [Qemu-devel] [PATCH 5/8] qmp: add block_job_set_speed command,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 3/8] block: add image streaming block job, Stefan Hajnoczi, 2011/10/27
- Re: [Qemu-devel] [PATCH 0/8] block: generic image streaming, Luiz Capitulino, 2011/10/27