[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/10] pxa2xx: memory API conversions
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH 00/10] pxa2xx: memory API conversions |
Date: |
Sun, 30 Oct 2011 13:59:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 |
On 10/26/2011 04:56 PM, Benoît Canet wrote:
> Convert most of pxa2xx periferal to memory API.
>
> pxa2xx_dmai.c was intact appart because it use
> cpu_physical_memory_read/write internal and seems special.
>
This patchset adds a lot of calls to get_system_memory(), which
undermines one of the purposes of the memory API - to avoid global
knowledge. Please make the various initialization functions accept a
MemoryRegion parameter, and use get_system_memory() in just one place
(the best place is the machine init callback).
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH 01/10] pxa2xx_gpio: convert to memory API, (continued)
- [Qemu-devel] [PATCH 01/10] pxa2xx_gpio: convert to memory API, Benoît Canet, 2011/10/26
- [Qemu-devel] [PATCH 02/10] pxa2xx_pcmcia.c: convert common memory space to memory API, Benoît Canet, 2011/10/26
- [Qemu-devel] [PATCH 03/10] pxa2xx_pcmcia.c: convert attribute memory space to memory API, Benoît Canet, 2011/10/26
- [Qemu-devel] [PATCH 04/10] pxa2xx_pcmcia.c: convert io memory space to memory API, Benoît Canet, 2011/10/26
- [Qemu-devel] [PATCH 05/10] pxa2xx_pcmcia.c: merge calls to get_system_memory(), Benoît Canet, 2011/10/26
- [Qemu-devel] [PATCH 07/10] pxa2xx_timer: convert to memory API, Benoît Canet, 2011/10/26
- [Qemu-devel] [PATCH 06/10] pxa2xx_keypad: convert to memory API, Benoît Canet, 2011/10/26
- [Qemu-devel] [PATCH 08/10] pxa2xx_pic: convert to memory API, Benoît Canet, 2011/10/26
- [Qemu-devel] [PATCH 09/10] pxa2xx_mmci: convert to memory API., Benoît Canet, 2011/10/26
- [Qemu-devel] [PATCH 10/10] pxa2xx_lcd: convert to memory API, Benoît Canet, 2011/10/26
- Re: [Qemu-devel] [PATCH 00/10] pxa2xx: memory API conversions,
Avi Kivity <=