|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] ia64-dis.c: Undefine ABS to avoid clash with glib |
Date: | Tue, 01 Nov 2011 13:04:05 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13 |
On 10/29/2011 06:58 AM, Peter Maydell wrote:
Undefine ABS to avoid a clash with the macro that glib.h helpfully defines for us (and a resulting build failure on ia64 hosts). Signed-off-by: Peter Maydell<address@hidden>
Applied. Thanks. Regards, Anthony Liguori
--- Bit of a namespace grab by glib.h if you ask me. Undefining ABS seems the most straightforward fix. ia64-dis.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/ia64-dis.c b/ia64-dis.c index 2886df3..2a103e6 100644 --- a/ia64-dis.c +++ b/ia64-dis.c @@ -781,6 +781,9 @@ ext_inc3 (const struct ia64_operand *self, ia64_insn code, ia64_insn *valuep) return 0; } +/* glib.h defines ABS so we must undefine it to avoid a clash */ +#undef ABS + #define CST IA64_OPND_CLASS_CST #define REG IA64_OPND_CLASS_REG #define IND IA64_OPND_CLASS_IND
[Prev in Thread] | Current Thread | [Next in Thread] |