[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH 09/11] fd_close(): check for close() errors too
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [RFC PATCH 09/11] fd_close(): check for close() errors too |
Date: |
Tue, 1 Nov 2011 17:20:28 -0200 |
In case close() fails, we want to report the error back.
Signed-off-by: Eduardo Habkost <address@hidden>
---
migration-fd.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration-fd.c b/migration-fd.c
index d0aec89..4d86d43 100644
--- a/migration-fd.c
+++ b/migration-fd.c
@@ -42,12 +42,14 @@ static int fd_write(MigrationState *s, const void * buf,
size_t size)
static int fd_close(MigrationState *s)
{
+ int r = 0;
DPRINTF("fd_close\n");
if (s->fd != -1) {
- close(s->fd);
+ if (close(s->fd) < 0)
+ r = -errno;
s->fd = -1;
}
- return 0;
+ return r;
}
int fd_start_outgoing_migration(MigrationState *s, const char *fdname)
--
1.7.3.2
- [Qemu-devel] [RFC PATCH 00/11] qemu_fclose() error handling fixes, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 04/11] migrate_fd_cleanup: accept any negative qemu_fclose() value as error, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 10/11] tcp_close(): check for close() errors too, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 02/11] QEMUFileCloseFunc: add return value documentation, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 01/11] savevm: use qemu_file_set_error() instead of setting last_error directly, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 11/11] unix_close(): check for close() errors too, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 07/11] stdio_fclose: return -errno on errors, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 03/11] exec_close(): accept any negative value as qemu_fclose() error, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 09/11] fd_close(): check for close() errors too,
Eduardo Habkost <=
- [Qemu-devel] [RFC PATCH 08/11] exec_close(): return -errno on errors, Eduardo Habkost, 2011/11/01
- [Qemu-devel] [RFC PATCH 05/11] qemu_fclose: return last_error if set, Eduardo Habkost, 2011/11/01
[Qemu-devel] [RFC PATCH 06/11] stdio_pclose: return -errno on error, Eduardo Habkost, 2011/11/01
Re: [Qemu-devel] [RFC PATCH 00/11] qemu_fclose() error handling fixes, Juan Quintela, 2011/11/02
Re: [Qemu-devel] [RFC PATCH 00/11] qemu_fclose() error handling fixes, Michael Roth, 2011/11/04