Re: [Qemu-devel] [PATCH 18/22] PPC: Fail configure when libfdt is not available

[Blue Swirl]

On Sun, Oct 30, 2011 at 20:23, Alexander Graf <address@hidden> wrote:
> We have several targets in the PPC tree now that basically require libfdt
> to function properly, namely the pseries and the e500 targets. This dependency
> will rather increase than decrease in the future, so I want to make sure
> that people building shiny new 1.0 actually have libfdt installed to get
> rid of a few ifdefs in the code.
>
> Warning: This patch will likely make configure fail for people who don't
> select their own --target-list, but don't have libfdt development packages
> installed. However, we really need this new dependency to move on.

I'd still prefer the submodule approach to help win32 and OSX users,
assuming that libfdt builds on those platforms.

> Signed-off-by: Alexander Graf <address@hidden>
>
> ---
>
> v1 -> v2:
>
>  - no paranthesis
>  - no fdt check for config_pseries
>  - add . in error message
> ---
>  configure |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index f8dd4db..18537e8 100755
> --- a/configure
> +++ b/configure
> @@ -3422,7 +3422,16 @@ case "$target_arch2" in
>       fi
>     fi
>  esac
> -if test "$target_arch2" = "ppc64" -a "$fdt" = "yes"; then
> +if test "$fdt" != "yes" && test "$target_arch2" = "ppc" -o \
> +        "$target_arch2" = "ppc64" -o "$target_arch2" = "ppcemb"; then
> +  echo
> +  echo "Error: libfdt missing"
> +  echo "The PowerPC target requires libfdt to work properly."
> +  echo "Please make sure to have it and its development packages installed."
> +  echo
> +  exit 1
> +fi
> +if test "$target_arch2" = "ppc64"; then
>   echo "CONFIG_PSERIES=y" >> $config_target_mak
>  fi
>  if test "$target_bigendian" = "yes" ; then
> --
> 1.6.0.2
>
>