Re: [Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in cow.c

[Stefan Hajnoczi]

On Fri, Nov 04, 2011 at 03:43:04PM +0800, Li Zhi Hui wrote:
> Since common file operation functions lack of error detection, 
> so change them to bdrv series functions.
> 
> Signed-off-by: Li Zhi Hui <address@hidden>
> ---
>  block/cow.c |   63 +++++++++++++++++++++++++++++++++-------------------------
>  1 files changed, 36 insertions(+), 27 deletions(-)

Please always send separate patches for coding style/whitespace changes.
Note that coding style changes are usually only worth it if you are
going to modify that function.  They make it harder for people trying to
follow the source history or backport commits because they perturb code.

I also suggest CCing Kevin Wolf <address@hidden> on any block layer
changes because he is the block layer maintainer.  It's a good idea to
check ./MAINTAINERS before sending a patch so you know the right people
to CC - it helps get their attention.

Stefan