[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/7] reorganize operation of "qemu-nbd -c" and f
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 0/7] reorganize operation of "qemu-nbd -c" and fix it |
Date: |
Tue, 08 Nov 2011 16:08:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 |
Am 04.11.2011 15:51, schrieb Paolo Bonzini:
> This is another approach to fixing the breakage of "qemu-nbd -c" due
> to mixing fork with threads. It switches operation of qemu-nbd to
> threads completely, with the exception of daemonization which is moved
> as early as possible to avoid conflicts with threads.
>
> Patches 1 and 2 are bugfixes to qemu-nbd, the first more or less
> unrelated, the second required by the rest of the patch.
>
> Patches 3 and 4 change "qemu-nbd -c" to operate within a single process.
> They are enough to fix the current breakage of "qemu-nbd -c -v", but not
> enough for "qemu-nbd -c". For that you need patch 5 too, which moves
> the daemonization to before the block layer is initialized.
>
> Patches 6 and 7 remove more warts that are now easily fixed.
>
> The patches are large, but unfortunately so is the breakage.
>
> Paolo Bonzini (7):
> nbd: treat EPIPE from NBD_DO_IT as success
> qemu-nbd: trap SIGTERM
> qemu-nbd: rename socket variable
> qemu-nbd: move client to a thread
> qemu-nbd: print error messages from the daemon through a pipe
> qemu-nbd: fix socket creation race condition
> qemu-nbd: open the block device after starting the client thread
>
> nbd.c | 7 ++
> qemu-nbd.c | 289 +++++++++++++++++++++++++++++++++++++++--------------------
> 2 files changed, 194 insertions(+), 102 deletions(-)
Thanks, applied all to the block-stable branch (for 1.0)
Kevin
- [Qemu-devel] [PATCH 0/7] reorganize operation of "qemu-nbd -c" and fix it, Paolo Bonzini, 2011/11/04
- [Qemu-devel] [PATCH 1/7] nbd: treat EPIPE from NBD_DO_IT as success, Paolo Bonzini, 2011/11/04
- [Qemu-devel] [PATCH 3/7] qemu-nbd: rename socket variable, Paolo Bonzini, 2011/11/04
- [Qemu-devel] [PATCH 2/7] qemu-nbd: trap SIGTERM, Paolo Bonzini, 2011/11/04
- [Qemu-devel] [PATCH 5/7] qemu-nbd: print error messages from the daemon through a pipe, Paolo Bonzini, 2011/11/04
- [Qemu-devel] [PATCH 4/7] qemu-nbd: move client to a thread, Paolo Bonzini, 2011/11/04
- [Qemu-devel] [PATCH 7/7] qemu-nbd: open the block device after starting the client thread, Paolo Bonzini, 2011/11/04
- [Qemu-devel] [PATCH 6/7] qemu-nbd: fix socket creation race, Paolo Bonzini, 2011/11/04
- Re: [Qemu-devel] [PATCH 0/7] reorganize operation of "qemu-nbd -c" and fix it,
Kevin Wolf <=