[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i386: derive '-cpu host' from KVM_GET_SUPPORTED
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH] i386: derive '-cpu host' from KVM_GET_SUPPORTED_CPUID |
Date: |
Wed, 09 Nov 2011 20:00:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 |
On 11/09/2011 07:56 PM, Anthony Liguori wrote:
> On 11/09/2011 07:44 AM, Avi Kivity wrote:
>> The fact that a host cpu supports a feature doesn't mean that QEMU
>> and KVM
>> will also support it, yet -cpuid host brings host features wholesale.
>>
>> We need to whitelist each feature separately to make sure we support it.
>> This patch adds KVM whitelisting (by simply using
>> KVM_GET_SUPPORTED_CPUID
>> instead of the CPUID instruction).
>>
>> Signed-off-by: Avi Kivity<address@hidden>
>
> This seems like a 1.0 candidate, yes?
There is a distinct possibility this will uncover bugs in kvm's
KVM_GET_SUPPORTED_CPUID. Those won't be qemu bugs, so I think it's good
for 1.0.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.