[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.0] configure: add '--disable-cocoa' switch
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1.0] configure: add '--disable-cocoa' switch |
Date: |
Thu, 10 Nov 2011 11:41:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 |
Am 09.11.2011 19:54, schrieb Pavel Borzenkov:
> When SDL support is disabled, there is no way to build QEMU without
> Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and
> allows to build QEMU without both SDL and Cocoa frontends.
>
> Signed-off-by: Pavel Borzenkov <address@hidden>
This is a new feature and therefore too late for 1.0. Only bugfixes now.
I remember there was a similar patch once but some issue with it kept us
from applying it - something unrelated to the frontend was influenced by
it I think... block layer?
> ---
> configure | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/configure b/configure
> index 9e5da44..ba3a830 100755
> --- a/configure
> +++ b/configure
> @@ -1424,10 +1429,6 @@ EOF
> if compile_prog "$sdl_cflags" "$sdl_libs" ; then
> if test "$_sdlversion" -lt 121 ; then
> sdl_too_old=yes
> - else
> - if test "$cocoa" = "no" ; then
> - sdl=yes
> - fi
Without looking at the context, this hunk looks weird. You sure you're
not breaking the SDL default for other platforms?
> fi
>
> # static link with sdl ? (note: sdl.pc's --static --libs is broken)
Anyway, I would much more appreciate a bugfix or suggestion how to make
Cocoa build than to disable it altogether (and then only based on a
configure option).
Andreas