[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/8] x86/cpuid: Fix crash on -cpu ""
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 7/8] x86/cpuid: Fix crash on -cpu "" |
Date: |
Thu, 10 Nov 2011 12:36:43 +0000 |
From: Markus Armbruster <address@hidden>
Spotted by Coverity.
Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
target-i386/cpuid.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
index 99cff65..21e5896 100644
--- a/target-i386/cpuid.c
+++ b/target-i386/cpuid.c
@@ -594,9 +594,9 @@ static int cpu_x86_find_by_name(x86_def_t *x86_cpu_def,
const char *cpu_model)
uint32_t numvalue;
for (def = x86_defs; def; def = def->next)
- if (!strcmp(name, def->name))
+ if (name && !strcmp(name, def->name))
break;
- if (kvm_enabled() && strcmp(name, "host") == 0) {
+ if (kvm_enabled() && name && strcmp(name, "host") == 0) {
cpu_x86_fill_host(x86_cpu_def);
} else if (!def) {
goto error;
--
1.7.7.1
- [Qemu-devel] [PULL 0/8] Trivial patches for 8 to 10 November 2011, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 6/8] x86/cpuid: Plug memory leak in cpudef_setfield(), Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 7/8] x86/cpuid: Fix crash on -cpu "",
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 1/8] qemu-tech.texi: Update default code cache size, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 3/8] qdev: Fix crash on -device '?=x', Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 4/8] ui/vnc: Convert sasl.mechlist to g_malloc() & friends, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 8/8] hw/lan9118.c: Add missing 'break' to fix buffer overrun, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 2/8] configure: Show --cpu option on the help list, Stefan Hajnoczi, 2011/11/10
- [Qemu-devel] [PATCH 5/8] x86/cpuid: Convert remaining strdup() to g_strdup(), Stefan Hajnoczi, 2011/11/10
- Re: [Qemu-devel] [PULL 0/8] Trivial patches for 8 to 10 November 2011, Anthony Liguori, 2011/11/10