[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6 v2] tests/Makefile: Remove qruncom target
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 2/6 v2] tests/Makefile: Remove qruncom target |
Date: |
Fri, 11 Nov 2011 16:19:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 |
Am 11.11.2011 16:07, schrieb 陳韋任:
> On Fri, Nov 11, 2011 at 03:02:16PM +0000, Peter Maydell wrote:
>> On 11 November 2011 14:53, Chen Wei-Ren (陳韋任) <address@hidden> wrote:
>>> From: Chen Wei-Ren <address@hidden>
>>>
>>> Remove qruncom target from the Makefile file since we have
>>> removed libqemu example (qruncom.c).
>>
>> This should be done before the patch removing qruncom.c, not after.
>> Or do both in the same patch.
>
> I'll reverse the order next time. Is there a rule of thumb about how
> to order those patches?
The logic goes like this: Every single patch should build / work.
If you remove the sources, the Makefile rule no longer works.
If you remove the Makefile rule, the sources are not used.
Therefore best just squash these two commits together.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 4/6 v2] Makefile.target: Remove libqemu target, (continued)
- [Qemu-devel] [PATCH 4/6 v2] Makefile.target: Remove libqemu target, 陳韋任, 2011/11/11
- [Qemu-devel] [PATCH 1/6 v2] tests/qruncom.c: Remove libqemu.a example, 陳韋任, 2011/11/11
- [Qemu-devel] [PATCH 5/6 v2] Makefile.objs: Remove libqemu_common.a from the comment, 陳韋任, 2011/11/11
- [Qemu-devel] [PATCH 6/6 v2] LICENSE: There is no libqemu.a anymore, 陳韋任, 2011/11/11
- [Qemu-devel] [PATCH 2/6 v2] tests/Makefile: Remove qruncom target, 陳韋任, 2011/11/11
- [Qemu-devel] [PATCH 3/6 v2] qemu-tech.texi: Remove libqemu related stuff from the document, 陳韋任, 2011/11/11